Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems status bar icon could open to that exact setting #199430

Closed
roblourens opened this issue Nov 28, 2023 · 1 comment · Fixed by #199457
Closed

Problems status bar icon could open to that exact setting #199430

roblourens opened this issue Nov 28, 2023 · 1 comment · Fixed by #199457
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
November 2023

Comments

@roblourens
Copy link
Member

Testing #199247

Instead of opening the settings editor to problems.visibility you could use @id:problems.visibility to show just that one setting.

@rzhao271 at one point when there was an exact ID match in the settings editor, we would only show that one setting. It seems like that is happening for some settings (like files.autoSave doesn't show files.autoSaveDelay) but here I see a bunch of results

image

did we get rid of that logic or is it just semantic matches kicking in?
@rzhao271
Copy link
Contributor

The logic is still there, but it's buggy because it didn't sort some entries properly 🤦

@rzhao271 rzhao271 mentioned this issue Nov 28, 2023
Merged
@rzhao271 rzhao271 assigned rzhao271 and unassigned justschen Nov 28, 2023
@rzhao271 rzhao271 added this to the November 2023 milestone Nov 28, 2023
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues confirmed Issue has been confirmed by VS Code Team member labels Nov 28, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 28, 2023
@justschen justschen mentioned this issue Nov 28, 2023
Merged
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 29, 2023
@roblourens roblourens added the verified Verification succeeded label Nov 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

fix: find exact match in unsorted array microsoft/vscode
4 participants
@roblourens @rzhao271 @justschen @vscodenpa