Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'EvaluateRequest' based data hovers #2012

Closed
weinand opened this issue Jan 14, 2016 · 1 comment
Closed

Support 'EvaluateRequest' based data hovers #2012

weinand opened this issue Jan 14, 2016 · 1 comment
Assignees
@weinand
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Milestone
Feb 2016

Comments

@weinand
Copy link
Contributor

weinand commented Jan 14, 2016

Currently the VSCode debug UI does not use evaluate requests for feeding data hovers and we do not want to change this implementation in general because it will break existing debug adapters. What we are planning is the following: based on "feature negotiation" (see microsoft/vscode-debugadapter-node#9) a debug adapter can announce that the VSCode debug UI should use the EvaluateRequest for data hovers. In this request VSCode will pass a new context string 'hover' to the debug adapter which implies that the evaluate should not allow side effects.

CC @gregg-miskelly @isidorn
@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 14, 2016
@weinand weinand assigned weinand and isidorn and unassigned weinand Jan 14, 2016
@weinand
Copy link
Contributor Author

weinand commented Jan 14, 2016

@isidorn the InitializeRequest now returns an attribute supportEvaluateForHovers and the EvaluateRequest accepts a category hover.

@isidorn isidorn added this to the Backlog milestone Jan 14, 2016
@isidorn isidorn modified the milestones: Feb 2016, Backlog Jan 22, 2016
@isidorn isidorn closed this as completed in 6437112 Feb 1, 2016
@egamma egamma mentioned this issue Feb 3, 2016
Closed
97 tasks
@isidorn isidorn assigned weinand and unassigned isidorn Feb 26, 2016
@weinand weinand added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
Feb 2016
Development

No branches or pull requests
2 participants
@weinand @isidorn