Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] language-configuration of embedded language not loading #202938

Open
RedCMD opened this issue Jan 20, 2024 · 2 comments
Open

[regression] language-configuration of embedded language not loading #202938

RedCMD opened this issue Jan 20, 2024 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-core Editor basic functionality important Issue identified as high-priority languages-basic Basic language support issues
Milestone

Comments

@RedCMD
Copy link
Contributor

RedCMD commented Jan 20, 2024

some optimization/bug is stopping the language-configuration of embedded languages from loading correctly when part of the embedded language is offscreen during file loading

Create a markdown file and paste in the following code

```latex


()

```

scroll down until you can no longer see ```latex, but still have () visible
reload VSCode (open & close etc)

scroll up and notice how the brackets () are no longer highlighted
typing a random letter near the latex code will start highlighting the brackets
typing a newline wont, nor will deleting any char

image
image

seems to also happen when the embedded language is within the visible screen space, but is inside a folded region

this was just showing "brackets", but it also applies to all other settings inside language-configuration.json

seems to be only 90% consistent. prob cause of some caching somewhere
VSCode 1.83.1 is fine ✅
some change in-between
VSCode 1.84.0 has the bug ❌

@aeschli aeschli assigned hediet and unassigned aeschli Jan 23, 2024
@hediet hediet added bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues editor-core Editor basic functionality labels Jan 24, 2024
@RedCMD RedCMD changed the title language-configuration of embedded language not loading when offscreen [regression] language-configuration of embedded language not loading when offscreen Feb 2, 2024
@RedCMD
Copy link
Contributor Author

RedCMD commented May 6, 2024

it seems the viewport position only changes the order in which lines update
as you can force the correct (breaking) order without positioning the viewport in any special way

paste this code in a Markdown file

```jsonX
{
	"patterns": [
		{
			"match": "(?x)(?<=((?!)))"
		}
	]
}
```

remove the X from jsonX
notice how none of the brackets have been highlighted 🐛

modify one of the lines inside the codeblock
brackets inside codeblock now highlight ✅

put the X back and then remove it again
brackets still work as they should ✅

it seems the update propagation isn't working correctly the first time a language loads
maybe an await is missing?

it also happens when a single line takes too long to tokenize
which I come across very often
image
vs
image

@RedCMD RedCMD changed the title [regression] language-configuration of embedded language not loading when offscreen [regression] language-configuration of embedded language not loading May 6, 2024
@RedCMD
Copy link
Contributor Author

RedCMD commented May 21, 2024

it's even worse now in the 1.89 release
typing a single letter now no longer updates the entire line anymore
it seems to update random parts of the line now

only the center 2 )( are highlighted
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-core Editor basic functionality important Issue identified as high-priority languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

3 participants