Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the notebook variable view when not applicable #203068

Closed
Tracked by #203480
amunger opened this issue Jan 22, 2024 · 3 comments · Fixed by #204789
Closed
Tracked by #203480

Don't show the notebook variable view when not applicable #203068

amunger opened this issue Jan 22, 2024 · 3 comments · Fixed by #204789
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-variables

Comments

@amunger
Copy link
Contributor

amunger commented Jan 22, 2024

We should at least keep the view collapsed if a notebook controller isn't able to provide variables.
Also hide/disable the view if the setting is disabled at any point.

@amunger amunger added bug Issue identified by VS Code Team member as probable bug notebook-variables labels Jan 22, 2024
@amunger amunger self-assigned this Jan 22, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Feb 9, 2024
@vscodenpa vscodenpa added this to the February 2024 milestone Feb 9, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 9, 2024
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Feb 22, 2024

Unfortunately I cannot get the variables view to show up.

@DonJayamanne
Copy link
Contributor

Install the github issues notebook extension

  • OPen ipynb file and Notebook Variables view is displayed
  • Open a gibuthubissues notebook and ensure the other ipynb is not visible
    I would expect the Notebook Variablers view to be hidden.

@DonJayamanne DonJayamanne reopened this Feb 22, 2024
@DonJayamanne DonJayamanne added the verification-found Issue verification failed label Feb 22, 2024
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Feb 22, 2024
@rzhao271 rzhao271 modified the milestones: February 2024, March 2024 Feb 22, 2024
@amunger amunger removed this from the March 2024 milestone Mar 22, 2024
@amunger amunger removed the verification-found Issue verification failed label Mar 22, 2024
@amunger
Copy link
Contributor Author

amunger commented Nov 22, 2024

I think we'll end up needing to show the variable more often for any open notebook and just showing the notebook variable source instead.

@amunger amunger closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug notebook-variables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants