Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default background color for multi-file diff editor is out of place #203309

Closed
joaomoreno opened this issue Jan 24, 2024 · 1 comment
Closed

Default background color for multi-file diff editor is out of place #203309

joaomoreno opened this issue Jan 24, 2024 · 1 comment
Assignees
@hediet
Labels
*duplicate Issue identified as a duplicate of another issue(s) ux User experience issues
Milestone
December / Januar...

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jan 24, 2024 •
edited
Loading

Testing #203075

It's too dark in both Light and Dark theme.

image Screenshot 2024-01-24 at 11 13 04

💡 Why not simply reusing the sidebar background color?

image image
@joaomoreno joaomoreno added the ux User experience issues label Jan 24, 2024
@hediet
Copy link
Member

hediet commented Jan 24, 2024

/duplicate #202137

@hediet hediet closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
*duplicate Issue identified as a duplicate of another issue(s) ux User experience issues
Projects
None yet
Milestone
December / January 2024
Development

No branches or pull requests
4 participants
@joaomoreno @hediet @aiday-mar @vscodenpa