Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCM accessibility help dialog #203577

Open
meganrogge opened this issue Jan 26, 2024 · 7 comments
Open

Add SCM accessibility help dialog #203577

meganrogge opened this issue Jan 26, 2024 · 7 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality scm General SCM compound issues
Milestone

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Jan 26, 2024

cc @jooyoungseo, @lszomoru

JooYoung mentioned there are some tab stops that aren't necessary here, making navigating it cumbersome.

He also indicated that we should give users an overview of this view and inform them of useful actions that can be taken.

@meganrogge meganrogge self-assigned this Jan 26, 2024
@meganrogge meganrogge added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality scm General SCM compound issues labels Jan 26, 2024
@meganrogge meganrogge modified the milestones: February 2024, March 2024 Jan 26, 2024
@lszomoru lszomoru self-assigned this Jan 27, 2024
@meganrogge
Copy link
Contributor Author

If possible, the changes should be tab navigable (right now a user has to use down arrow to reach them)

@jooyoungseo
Copy link

jooyoungseo commented Feb 6, 2024 via email

@meganrogge
Copy link
Contributor Author

#210255

@meganrogge
Copy link
Contributor Author

meganrogge commented Apr 26, 2024

consolidating issues:

SCM view needs some commands exposed because atm, you have to focus the SCM view and then tab or use space/arrow keys to get to these.

focus commit message
focus staged changes (not tabbable)
focus changes (not tabbable)
We should add !screenReaderEnabled to this keybinding so users can review their commit messages without going up in history

{ "key": "up", "command": "scm.viewPreviousCommit", "when": "scmInputIsInFirstPosition && scmRepository && !suggestWidgetVisible" }

@lszomoru
Copy link
Member

The latest VS Code Insiders release contains commands to focus next/previous input/resource group:

  • workbench.scm.action.focusNextInput
  • workbench.scm.action.focusPreviousInput
  • workbench.scm.action.focusNextResourceGroup
  • workbench.scm.action.focusPreviousResourceGroup

@jooyoungseo, please give them a try and let me know if they are working as expected. Thanks!

@lszomoru
Copy link
Member

@meganrogge, is there anything else outstanding on this issue or can we close it? Thanks!

@lszomoru lszomoru modified the milestones: May 2024, June 2024 May 28, 2024
@meganrogge
Copy link
Contributor Author

just the accessibility help dialog for the SCM view

@joaomoreno joaomoreno changed the title Review SCM view accessibility, add accessibility help dialog Add SCM accessibility help dialog Jun 5, 2024
@joaomoreno joaomoreno removed this from the June 2024 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality scm General SCM compound issues
Projects
None yet
Development

No branches or pull requests

4 participants