Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer.upload fails when a file is selected #206274

Open
benvillalobos opened this issue Feb 26, 2024 · 3 comments
Open

explorer.upload fails when a file is selected #206274

benvillalobos opened this issue Feb 26, 2024 · 3 comments
Assignees
Labels
file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@benvillalobos
Copy link
Member

benvillalobos commented Feb 26, 2024

Our tracking issue: https://github.com/microsoft/vscode-edu-extension/issues/1664#issuecomment-1962165842. Demo gif here: https://github.com/microsoft/vscode-edu-extension/issues/1664#issuecomment-1962159858

When executing explorer.upload while a file is selected, vscode fails with the following message:

When a file is selected
uploading foo.txt and foo.txt is selected

Unable to write file 'vscode-edu-user:/VSCode Edu Project/foo.txt/foo.txt' (Error: Unable to create folder 'vscode-edu-user:/VSCode Edu Project/foo.txt' that already exists but is not a directory)

To work around this, I've considered detecting if a file is selected and showing a warning message to the user, but we can't get the currently selected file in the explorer today.

Version: 1.87.0-insider
Commit: e73419b
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36 Edg/121.0.0.0
Embedder: vscode.dev

@benvillalobos benvillalobos changed the title explorer.upload fails when a file or folder is selected explorer.upload fails when a file is selected Feb 26, 2024
@lramos15
Copy link
Member

I do not have access to the linked repository.

@asmeets
Copy link

asmeets commented Feb 29, 2024

@lramos15 I'll loop back with you and @bamurtaugh to provide some context, as well as the link to join our internal repo for the connected issues. Thanks!

@rzhao271 rzhao271 added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Dec 16, 2024
@rzhao271
Copy link
Contributor

Hi all, are you still seeing this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants