Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow execution of all cells in Notebooks when working on large notebooks with image outputs #207766

Closed
DonJayamanne opened this issue Mar 14, 2024 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook on-testplan perf verified Verification succeeded
Milestone

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 14, 2024

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: N/A
  • OS Version: N/A

Steps to Reproduce:

  1. Create a Jupyter notebook
  2. Add a code cell with the following code
from IPython import display
display.Image("<valid path>/output.png")
  1. Run the above cell
  2. Now copy and paste this cell a few 100 times, at least 200-300 times
  3. Save the notebook
  4. Run one cell verify the cell runs
  5. Open Jupyter extension logs (output panel) and clear it
  6. Hit run all button
  7. Problem 1: Notice that Jupyter extension logs do not get updated with anything and execution does not start for a few seconds.
    Depending on the machine this can take a few seconds, event 40s.
    After 40s, Jupyter extension finally gets the message from VS Code renderer process to run the cells
    Now cells run to completion in 3-5s.
  8. Problem 2: Now run a single cell, and we can still see the same delays.

Summary

  • Perception is execution takes a few minutes
  • In reality Jupyter extension runs in a few seconds (<5s)
  • VS Code renderer process is busy doing something when we hit run all
@DonJayamanne DonJayamanne self-assigned this Mar 14, 2024
@DonJayamanne DonJayamanne changed the title Slow execution of Notebooks when working on large notebooks with image outputs Slow execution of all cells in Notebooks when working on large notebooks with image outputs Mar 14, 2024
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug perf notebook labels Mar 14, 2024
@DonJayamanne DonJayamanne added verified Verification succeeded on-testplan labels Apr 26, 2024
@DonJayamanne DonJayamanne added this to the April 2024 milestone Apr 26, 2024
@DonJayamanne
Copy link
Contributor Author

Closing as fixed

@DonJayamanne
Copy link
Contributor Author

Addressed as part of #209787

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook on-testplan perf verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

1 participant