-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[git] Add extension api event for when a file is commit #20845
Comments
You should listen to file system events on the |
@joaomoreno that is an excellent suggestion! Thanks so much. |
@joaomoreno but at the same time. Vscode must already be doing this to update it's tracking. And with more scm's being added an abstract event would seem to me to be very valuable |
Code is listening. But it won't tell you that a file has been committed. At best, it can tell you that something has changed. Which is exactly what you can do with FS events. |
True, but when there are multiple different SCM providers, it allows an extension to not have to know about the details of each one (and vscode will already need to know). |
It won't actually know. The SCM support is more abstract than that, since some SCM systems don't even have the commit concept. |
Sorry, I was conflating things. I just meant a general SCM changed type of event (with optional other details if possible - but would be specific to the SCM) |
1.10.0-insider
50f884810.12.3 (16D32)
I would love to be able to listen for an event for when the a file in an open editor has been committed. Currently we have api events for when a document changes and is saved, but nothing for when a document is commit.
Specifically this would help out GitLens, to where I could avoid issues where the blame continues to show "Uncommitted changes" because I haven't detected that the file has been committed.
The text was updated successfully, but these errors were encountered: