-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip comments entirely when evaluating indentation #209861
Comments
I think this is a good idea |
After discussion with my colleagues, we decided this would be forced. That is comments will never be considered in the indentation evaluation. |
Fixed with #210641. This PR actually treats strings, regexe and comment tokens in a similar manner. The language configuration brackets in these tokens are stripped and the indentation rules are evaluated on the stripped lines |
In relation to #209519
As part of the indentation improvement, we would like to entirely strip comments from the current line being considered before evaluating the indentation rules
Simplify the indentation regexes in order not to take into account comment placements for indentation.
The text was updated successfully, but these errors were encountered: