Custom Hover in REPL freezes the UI

[rebornix]

Does this issue occur when all extensions are disabled?: Yes/No

I ran into this pretty often while debugging extensions

and digging into the call stack, it's coming from custom hover handler for REPL

[Tyriar]

Guessing this is a consequence of using the more convenient but less performance-conscioussetupUpdatableHover?

[rebornix]

adding important as currently VS Code is barely usable while debugging Copilot.

[Tyriar]

+@aiday-mar was this change part of the hover enriching work you did? I think when using hovers extensively like this you need to move off setupUpdatableHover and manage things yourself via IHoverService.showHover

[aiday-mar]

Hi @Tyriar probably not, the hover enriching work is not merged yet. I have done some refactoring on the content hover however so if there is a link somewhere to the content hover code it could be caused by that.

[benibenj]

This might be the culprit if the problem is hover related: #209058
Here is where the hover is being setup. But I don't really see a problem with this call.

@connor4312 Do you think this is actually hover related? It looks like there are a lot of renderElement calls. If 20 items are visible and the hover setup takes around 5ms then this would account for "only" 100ms of the 5s shown in the trace.

[Tyriar]

Hover does seem like the majority but linkify is also awfully expensive there 🤔

[connor4312]

I assume this happens when a breakpoint gets hit, do you recall where you placed that breakpoint when you got that profile @rebornix?

[rebornix]

@connor4312 I used breakpoints briefly while debugging, but I can' recall if they were still enabled when I did the profile.

[connor4312]

Do you know in general what you were doing so I can try to reproduce? I don't think I've hit this before in my debugging.

The only slowness I get in the copilot repo is when dealing with source map renames making the initial 'variables' view slow to load (TBD whether there's much I can to do speed that up) but that's not renderer-blocking.

[rebornix]

Coming back a bit late. I don't really have a good reproduce.

[connor4312]

Fixed in microsoft/vscode-js-debug#2000