Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saving notebook files should happen on extension host by default #211730

Open
amunger opened this issue Apr 24, 2024 · 0 comments
Open

Saving notebook files should happen on extension host by default #211730

amunger opened this issue Apr 24, 2024 · 0 comments
Assignees
@amunger
Labels
bug Issue identified by VS Code Team member as probable bug notebook-workflow Issues that interrupt expected or desirable behavior

Comments

@amunger
Copy link
Contributor

amunger commented Apr 24, 2024

Right now, the setting "notebook.experimental.remoteSave": true can be used to save the file on the EH instead of needing a trip to the renderer. We should try to enable this behavior by default.

Need to handle this issue #209291. It's hard to repro, but seems to come from this new code path.
@amunger amunger added bug Issue identified by VS Code Team member as probable bug notebook-workflow Issues that interrupt expected or desirable behavior labels Apr 24, 2024
@amunger amunger self-assigned this Apr 24, 2024
@amunger amunger transferred this issue from microsoft/vscode-jupyter Apr 30, 2024
@amunger amunger mentioned this issue Apr 30, 2024
Closed
@kieferrm kieferrm mentioned this issue May 6, 2024
Closed
52 tasks
This was referenced May 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amunger amunger

Labels
bug Issue identified by VS Code Team member as probable bug notebook-workflow Issues that interrupt expected or desirable behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amunger