Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce NotebookDocumentChangeEvent#reason #212063

Open
rebornix opened this issue May 6, 2024 · 0 comments
Open

Introduce NotebookDocumentChangeEvent#reason #212063

rebornix opened this issue May 6, 2024 · 0 comments
Assignees
Labels
debt Code quality issues notebook-api
Milestone

Comments

@rebornix
Copy link
Member

rebornix commented May 6, 2024

Had a discussion with @dbaeumer and learnt that adding reason was perhaps not sufficient or not what was required.
Salient points of the meeting:

  • Existing event is unfortunately a little complex and difficult to use/understand, as this event can be triggered for a number of reasons related to notebook content and notebook execution state changes.
    • Hence consumers will likely make assumptions when consuming this event.
  • When consuming this event (at least in the case of LSP)
    • Difficult to understand the current execution state (starting, executing, stopped, etc)
    • Are changes a result of execution or other

A follow up discussion will be required with @dbaeumer and a few others to some of the above issues (& possibly others, if any) are addressed

For #211142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues notebook-api
Projects
None yet
Development

No branches or pull requests

2 participants