Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align rendering of links #21347

Closed
jrieken opened this issue Feb 24, 2017 · 4 comments
Closed

Align rendering of links #21347

jrieken opened this issue Feb 24, 2017 · 4 comments
Assignees

Comments

@jrieken
Copy link
Member

jrieken commented Feb 24, 2017

re #21021

See attached screen shot. Initially I thought links don't work because they get the underline only on hover while the editor is more eager to render links. We should align them, obviously I am used the editor style but open for anything...

screen shot 2017-02-24 at 12 25 14

@Tyriar
Copy link
Member

Tyriar commented Feb 24, 2017

I'm not so sure aligning is the best thing here. This is why I didn't make terminal links always on:

  • gnome-terminal shows the under line on hover
  • There is not as much line-height to play with in the terminal, unlike the editor the terminal uses native web selection which you cannot change the height of outside of changing the font-size.
  • Terminal links are rendered 200ms later for performance reasons. Evaluating the links is resource intensive and adding links causes a layout. This aspect is completely hidden when the links show on hover.
  • Adding text decoration underline makes the text harder to read, using a border would as well due to less line-height.

@alexdima
Copy link
Member

I am ok with having them rendered differently.

It is also my understanding that the terminal is much more permissive with links (i.e. for file paths) and that would result in a lot of underlines in potentially unwanted places.

@alexdima alexdima removed their assignment Feb 27, 2017
@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2017

RE permissive links: This is a temporary situation which will be improved in #21226

@Tyriar
Copy link
Member

Tyriar commented Apr 21, 2017

They're now rendered the same as symbols in the editor.

@Tyriar Tyriar closed this as completed Apr 21, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants