Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Intellisense for module import #2153

Closed
SetTrend opened this issue Jan 21, 2016 · 4 comments
Closed

Provide Intellisense for module import #2153

SetTrend opened this issue Jan 21, 2016 · 4 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@SetTrend
Copy link

TypeScript module exports can be fairly opaque in regard to their exports. Particularly when modules grow bigger.

With bigger modules (particularly with modules exporting other modules' exports) it becomes very hard to see which entities a module actually is exporting.

So I suggest to provide an Intellisense feature for module imports, which
  1. provides a file browser dropdown box displaying valid module files
  2. provides a module browser dropdown box displaying an imported module's exported entities

#### The first part of the suggestion I propose to work like `LINQ`:

After entering the keyword from and hitting the [TAB] key, a file browser dropdown should be displayed, listing all valid module files. After confirming a file from the dropdown box, VS Code should automatically create a full import {} from "[...]" statement, move the cursor position between the curly braces and display a dropdown box listing all the exports of that module.

Here's a visualization:

provide intellisense for import


#### The second part of the suggestion I propose to work like common Intellisense:

Everytime when hitting [CTRL]+[SPACE] from within the curly braces of an import statement, dropdown box (2) should be displayed, listing the module's exported entities. Selecting an entry should then add the selected export entity to the list of already imported entities within the curly braces.

@SetTrend SetTrend changed the title Support Intellisense for module import Provide Intellisense for module import Jan 21, 2016
@weinand weinand added feature-request Request for new features or functionality typescript Typescript support issues labels Jan 21, 2016
@dbaeumer dbaeumer added this to the Backlog milestone Jan 22, 2016
@atifsyedali
Copy link

We have around 25k lines of Typescript with hundreds of Typescript modules, and we use CommonJS style module imports.

Not having Intellisense for module import as described here is the main reason why we don't use VS Code. Would be really nice if you can add this (or push the Typescript team to provide it on a language service level :) )

@Haemoglobin
Copy link

👍

@dbaeumer dbaeumer removed feature-request Request for new features or functionality typescript Typescript support issues labels Aug 2, 2016
@dbaeumer dbaeumer removed this from the Backlog milestone Aug 2, 2016
@dbaeumer dbaeumer removed their assignment Aug 2, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Aug 2, 2016

This is actually a feature that has to come from the tsserver.

@dbaeumer
Copy link
Member

dbaeumer commented Aug 2, 2016

This issue was moved to microsoft/TypeScript#10092

@dbaeumer dbaeumer closed this as completed Aug 2, 2016
@dbaeumer dbaeumer added typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 2, 2016
@dbaeumer dbaeumer self-assigned this Aug 2, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

5 participants