Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show basic info on unsupported file #216586

Closed
ecstrema opened this issue Jun 19, 2024 · 7 comments
Closed

Show basic info on unsupported file #216586

ecstrema opened this issue Jun 19, 2024 · 7 comments
Labels
feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window

Comments

@ecstrema
Copy link
Contributor

When an unsupported or binary file is opened, it shows this:
image

I however quite often open these in vscode to check some basic file properties, like file size (I have the file-size extension, which shows the file size in the bottom bar)

I think these should be shown by default: what about something like this?

image

This should happen around this part of the code:

label: localize('binaryError', "The file is not displayed in the text editor because it is either binary or uses an unsupported text encoding."),

@bpasero
Copy link
Member

bpasero commented Jun 19, 2024

File size is shown in the status bar bottom right:

image

@bpasero bpasero added feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window labels Jun 19, 2024
@bpasero bpasero removed their assignment Jun 19, 2024
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Jun 19, 2024
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@ecstrema
Copy link
Contributor Author

ecstrema commented Jun 20, 2024

File size is shown in the status bar bottom right:

@bpasero true, but

  1. Not by default, this comes from an extension: https://marketplace.visualstudio.com/items?itemName=mkxml.vscode-filesize Actually it's there by default, you're right, I checked on vscode.dev to quickly check with extensions disabled, but it is not supported on vscode for the web
  2. It's an empty editor, we can do more than leave it empty

@bpasero
Copy link
Member

bpasero commented Jun 20, 2024

It comes by default, I do not have any extension installed.

@ecstrema
Copy link
Contributor Author

Right but I still think we can do better than this "empty" editor

Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

4 participants