Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Electron Crash reporter for all processes after Electron update #21944

Closed
ramya-rao-a opened this issue Mar 3, 2017 · 4 comments
Closed

Enable Electron Crash reporter for all processes after Electron update #21944

ramya-rao-a opened this issue Mar 3, 2017 · 4 comments
Assignees
@ramya-rao-a
Labels
electron Issues and items related to Electron engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@ramya-rao-a
Copy link
Contributor

Once a newer version (>= 1.5.1)of electron is adopted, all node processes spawned in VS Code need to initialize the crash reporter

https://github.com/electron/electron/blob/master/docs/api/crash-reporter.md#methods
@ramya-rao-a ramya-rao-a added this to the March 2017 milestone Mar 3, 2017
@ramya-rao-a ramya-rao-a self-assigned this Mar 3, 2017
@kieferrm kieferrm mentioned this issue Mar 3, 2017
Closed
58 tasks
@ramya-rao-a ramya-rao-a modified the milestones: April 2017, March 2017 Mar 16, 2017
@ramya-rao-a ramya-rao-a added feature-request Request for new features or functionality electron-update labels Apr 10, 2017
@ramya-rao-a ramya-rao-a modified the milestones: May 2017, April 2017 Apr 25, 2017
@bpasero bpasero added the electron Issues and items related to Electron label Apr 29, 2017
@kieferrm kieferrm mentioned this issue May 5, 2017
Closed
44 tasks
@ramya-rao-a ramya-rao-a mentioned this issue May 24, 2017
Merged
@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented May 31, 2017 •
edited
Loading

For the May milestone, we have enabled the crash reporter in the child process that starts the extension host.

@ramya-rao-a ramya-rao-a modified the milestones: June 2017, May 2017 May 31, 2017
@bpasero
Copy link
Member

bpasero commented May 31, 2017

And only on macOS.

@kieferrm kieferrm mentioned this issue Jun 9, 2017
Closed
30 tasks
@ramya-rao-a ramya-rao-a modified the milestones: July 2017, June 2017 Jun 26, 2017
@kieferrm kieferrm mentioned this issue Jul 6, 2017
Closed
39 tasks
@bpasero
Copy link
Member

bpasero commented Jul 11, 2017

@ramya-rao-a fyi I am not convinced this actually works, so far I did not find a crash from the extension host on HockeyApp. Maybe you could also have a look.

@ramya-rao-a ramya-rao-a modified the milestones: August 2017, July 2017 Aug 2, 2017
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, August 2017 Aug 29, 2017
@bpasero bpasero added workbench upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed electron-update labels Nov 11, 2017
@ramya-rao-a ramya-rao-a added the engineering VS Code - Build / issue tracking / etc. label Nov 16, 2017
@ramya-rao-a
Copy link
Contributor Author

ramya-rao-a commented Sep 11, 2018 •
edited
Loading

Closing this in favor of #36540.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
electron Issues and items related to Electron engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bpasero @ramya-rao-a