Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize altKey correctly on macOS #22664

Closed
AriaMinaei opened this issue Mar 15, 2017 · 1 comment
Closed

Recognize altKey correctly on macOS #22664

AriaMinaei opened this issue Mar 15, 2017 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone

Comments

@AriaMinaei
Copy link

AriaMinaei commented Mar 15, 2017

  • VSCode Version: 1.11.0-insider (6a00291)
  • OS Version: macOS Sierra 10.12.3

Steps to Reproduce:

  1. Define this keybinding and try it: {"key": "alt+u", "command": "cursorHome"}

What's expected: For cursorHome command to be invoked.
What actually happens: This character gets written: ¨

Atom used to have this problem too, which was solved by this PR: atom/atom-keymap#163

More context: atom/atom#13043

@AriaMinaei AriaMinaei changed the title Recognize altKey as AltGraph on macOS Recognize altKey correctly on macOS Mar 17, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in today's Insiders build) appear to behave correctly for this key combination. I have tested under the US layout.

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X keybindings VS Code keybinding issues labels Mar 24, 2017
@alexdima alexdima added this to the March 2017 milestone Mar 24, 2017
@jrieken jrieken added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants