Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Doc refers to onDidActivateTerminalShellIntegration which doesn't exist as API #226749

Closed
dbaeumer opened this issue Aug 27, 2024 · 0 comments · Fixed by #227004
Closed

JS Doc refers to onDidActivateTerminalShellIntegration which doesn't exist as API #226749

dbaeumer opened this issue Aug 27, 2024 · 0 comments · Fixed by #227004
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
August 2024

Comments

@dbaeumer
Copy link
Member

Testing #226655

See

vscode/src/vscode-dts/vscode.d.ts

Line 7508 in 7473068

* window.onDidActivateTerminalShellIntegration(async ({ terminal, shellIntegration }) => {

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Aug 27, 2024
@Tyriar Tyriar added this to the August 2024 milestone Aug 27, 2024
@Tyriar Tyriar mentioned this issue Aug 28, 2024
Merged
@Tyriar Tyriar closed this as completed in b272c80 Aug 28, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 28, 2024
@dbaeumer dbaeumer added the verified Verification succeeded label Aug 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

Fix api docs referencing old name microsoft/vscode
2 participants
@dbaeumer @Tyriar