onDidChangeTerminalShellIntegration fired twice on terminal creation without reason property

[meganrogge]

Testing #226655

Set a breakpoint in the terminal-shell-integration sample here:

vscode.window.onDidChangeTerminalShellIntegration(e => {
// breakpoint
}

See that it's hit twice. I'd expect it to only be hit once. I read the documentation, which indicates this is fired when any property changes. I wonder if we should have a reason on the event to make this clear?

twice.mov

[legomushroom]

Was able to re-confirm the behaviour today on stable 1.96.0 so the issue is still relevant. I agree that the reason or some other property to rely on would be a great addition 👍