Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findFiles2New Should cancel return an [] array #226914

Closed
karthiknadig opened this issue Aug 28, 2024 · 2 comments
Closed

findFiles2New Should cancel return an [] array #226914

karthiknadig opened this issue Aug 28, 2024 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@karthiknadig
Copy link
Member

Testing #226670

Should it return CancellationError instead?

@andreamah
Copy link
Contributor

Taking a quick look at finalized API, we don't seem to throw CancellationToken upon cancellation too much (especially considering that there are lots of APIs that have this token-to-cancel style of calling).

@jrieken You're probably the expert on whether we should be throwing CancellationToken- I'm willing to make the change if it's consistent with others.

@andreamah andreamah added the info-needed Issue requires more information from poster label Aug 29, 2024
@jrieken
Copy link
Member

jrieken commented Aug 30, 2024

Let's stick with what the current API does.

@andreamah andreamah closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants