Incorrect behavior of granting access for the extension to existing authentication session using Manage Trusted Extensions functionality

[AnnaSalata]

Does this issue occur when all extensions are disabled?: This issue occurs with VS Code functionality FOR the extensions.

• VS Code Version: 1.92.2
• OS Version: macOS 13.6.8

Steps to Reproduce:

1. Create an extension with AuthenticationProvider, based on the sample: https://github.com/microsoft/vscode-extension-samples/blob/main/authenticationprovider-sample/src/authProvider.ts
2. Sign in, using credentials.
3. Go to Accounts -> extension's account -> Manage Trusted Extensions:

4. Observe the list of trusted extensions for the selected account:

5. Uncheck the extension from the list of trusted and press OK:

6. Observe an event is fired inside vscode.authentication.onDidChangeSessions subscription and method await vscode.authentication.getSession(MyAuthenticationProvider.id, [], { createIfNone: false }) returns undefined:

7. Observe the option Grant access to {Auth Provider} for {Extension}... (1) appeared under the Accounts menu:

8. Select Accounts -> Grant access to {Auth Provider} for {Extension}... (1)
9. Observe a confirmation popup and press Allow:

10. Observe an event is fired inside vscode.authentication.onDidChangeSessions subscription and method await vscode.authentication.getSession(MyAuthenticationProvider.id, [], { createIfNone: false }) returns session:

11. Observe Grant access to My Provider for My Extension... (1) is no longer exists in the Accounts menu:

12. Repeat steps 3 - 7 for removing the extension from the list of trusted extensions again.
13. Navigate to Accounts -> extension's account -> Manage Trusted Extensions
14. Check the extension as trusted and press OK:

15. An event is fired inside vscode.authentication.onDidChangeSessions subscription and method await vscode.authentication.getSession(MyAuthenticationProvider.id, [], { createIfNone: false }) returns session:

Actual Result:

Grant access to My Provider for My Extension... (1) is still available in the Accounts menu, even though access has been granted:

Expected Result:

• Grant access to My Provider for My Extension... (1) should NOT be available in the Accounts menu.

Consequences:

Since VS Code doesn’t provide a direct API to detect when the extension is checked/unchecked in the "Manage Trusted Extensions" dialog, it is impossible to work with authentication correctly.
While both, user account and Grant access to My Provider for My Extension... (1) are available in the Accounts menu, it allows the possibility to sign in under two accounts, even if { supportsMultipleAccounts: false } was passed during registering the Authentication Provider, using

context.subscriptions.push(
    vscode.authentication.registerAuthenticationProvider(
      'myCustomProvider',
      'My Provider,
      new MyAuthenticationProvider (context.secrets),
      { supportsMultipleAccounts: false },
    ),
  );

To reproduce this behavior follow these steps:

1. Navigate to Accounts -> account -> Sign Out
2. Observe Sign In with My Provider to use My Extension (1) appeared in the Accounts menu
3. Sign in, using another account
4. Observe new user account appeared in the Account menu.
5. Press Grant access to My Provider for My Extension... (1)
6. Observe both, previous and new account for the same extension presented in the Accounts menu.

[TylerLeonhardt]

You basically want this: #104008

but this bug can track the fact that, yes, if you grant access via the Trusted Extensions quick pick, it should clean up any account menus.

[AnnaSalata]

You basically want this: #104008

but this bug can track the fact that, yes, if you grant access via the Trusted Extensions quick pick, it should clean up any account menus.

Well yes, I think there should be at least one option available here: an api providing possiblity to track when access is granted/revoked, as described in #104008, or Accounts menu item Grant access to My Provider for My Extension... (1) should work correctly and disappear from menu when user grants access directly or indirectly.