Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor find widget cropped in AUX window #227546

Closed
jrieken opened this issue Sep 4, 2024 · 4 comments · Fixed by #229001
Closed

Editor find widget cropped in AUX window #227546

jrieken opened this issue Sep 4, 2024 · 4 comments · Fixed by #229001
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member editor-find Editor find operations good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.

Comments

@jrieken
Copy link
Member

jrieken commented Sep 4, 2024

  • move editor into its own window
  • trigger find
  • the input box is cropped, the border isn't fully visible

Image

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations confirmed Issue has been confirmed by VS Code Team member workbench-auxwindow Issues related to use of auxiliary ("floating") windows. help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Sep 4, 2024
@bpasero bpasero added this to the On Deck milestone Sep 4, 2024
@bpasero
Copy link
Member

bpasero commented Sep 4, 2024

I can reproduce and I am puzzled as to why this is. Opening for help wanted for a CSS wizard to step in if possible.

Steps:

  • open a text editor in the main window
  • open the find widget and focus it, notice how the blue outline color goes all the way around the input box ✅
  • right click into the editor tab and "Copy into New Window"
  • do the same and notice that the outline is cropped 🛑

I already see that the wrapper around the textarea is 23px in the main window and 25px in the auxiliary window 🤯

Image

Image

CSS is defined from here:

.monaco-inputbox > .ibwrapper {
position: relative;
width: 100%;
height: 100%;
}

and

.monaco-editor .find-widget .monaco-inputbox .input {

@qasimahmadkhan
Copy link

@bpasero I can fix this, please assign me this issue if it's still open

@bpasero
Copy link
Member

bpasero commented Sep 5, 2024

@qasimahmadkhan we cannot assign issues to non-members of the team, but feel free to open a PR. Thanks!

@qasimahmadkhan
Copy link

@bpasero sure, thanks for letting me know.

@bpasero bpasero modified the milestones: On Deck, September 2024 Sep 19, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 19, 2024
@jrieken jrieken added the verified Verification succeeded label Sep 26, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member editor-find Editor find operations good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants