Horizontal panel separator look bogus

[jrieken]

I don't understand why it uses the status bar background color and that it even changes when debugging. It should use a more similar style as the sidebar does (background et al) and not look like an editor

[isidorn]

As designed, please comment on the issue here #1876 where the current design is explained and it also links to other issues where this is discussed

[jrieken]

disagree - we should discuss this in the team

[isidorn]

Setting to jan for discussion

[jrieken]

@bgashler1, @stevencl fyi

...like the way you used colour in option 2 to indicate whether content in the panel is 'live' or 'hot' as you called it...

While that makes sense for the debug panel is doesn't for the output view. Take git which runs constantly and produces output all the time. Now depending on the debug status that is shown as 'hot' or not which is misleading.

I think it should use the title color of viewlets because it's just another part and it should also use their background color because it is a non-editable part.

[stevencl]

We discussed this quite a bit before deciding to proceed with the design as it is. We understand the concern you have raised but we aren't sure how significant the consequences are. Is there something about the colour that you think will cause the user to misinterpret the output they are reading and cause them to take an incorrect action?

One thing I wonder about is whether or not the blue colour might be interpreted as indicating that focus is inside the panel. Now that we are doing this work to indicate focus, this might be another reason to rethink this design.

The main aim remains the same - we need to ensure that the horizontal panel can be distinguished from an editor.

[jrieken]

We usually don't use strong contour lines but separation by extensive backgrounds (see sidebar & editor). That's why I am irritated by the harsh line being drawn between editor and bottom panel. I would suggest to continue using the background stylings to separate editable from non-editable (primary/secondary) content.

I didn't think of focus indication but you do make a point there

[stevencl]

Yes, we will revisit this.

[isidorn]

Giving to Brad so he is aware of feedback.
Once we collect all the feedback we can revisit what exactly to do here.

[bgashler1]

Thanks everyone for taking a good look at this. Are we targeting the February milestone to update this?
_EDIT:_ Just noticed we are. Ok, I'll be working on some new design proposals starting after end game week based off the feedback and this discussion.

[jrieken]

awesome

[jrieken]

Btw my choice of color are shown here: #1875 (comment)

[bgashler1]

@jrieken, how does this look to you? It's gray now, so it's not misleading—in the case that a user is looking at Git output. It's also lightweight and gracefully avoids becoming a viewlett.

.monaco-workbench>.part.panel>.title { border-color: rgba(127, 127, 127, 0.34902); }

FYI - @stevencl

[bgashler1]

I can push this change if you're happy with it.

[isidorn]

@bgashler1 we will discuss this during the standup and if we decide to do it I can push it. Thanks