Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Show failed lookup path for not found modules & more #23003

Closed
aight8 opened this issue Mar 22, 2017 · 2 comments
Closed

Feature Request: Show failed lookup path for not found modules & more #23003

aight8 opened this issue Mar 22, 2017 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster typescript Typescript support issues

Comments

@aight8
Copy link

aight8 commented Mar 22, 2017

This is a feature request

I experienced that typescript's ts-config is somehow very difficult to debug - and I spend some nights to get understand how the resolution thing works. This is however typescript related, but what can do vscode better?

Current very serious problems:

  • I don't know which tsconfig file was used for the workspace - especially if you have nested packages - even if it is always the root one - It must be explicitly showed somewhere
  • I learn a lot about type acquisition - but I never know what it acquire. It were very helpful if vscode could provide the list of acquired files. I don't know until now how it exactly, and to be honest I have no clue how I can figure this out. Somewhere I read about the "global.d.ts" to include - It never worked - only the node_modules/@types folder was affected.
  • When I experiment with the tsconfig I never know what's the typescript server is doing after a change. Sometimes it reloads sometimes not or after an unknown time. Because this is the case, it breaks me my last leg to at least get a clue how my config changes affects
  • Show failed lookup path for not found modules - How I said at the beginning it is very difficult to debug the module/type resolution part, the only information I get is "module not found" - it were so much better if at least the failedLookup list were showed in the problem entry - it would at least give me a clue if I'm on the right road

Please, please improve at least some those things, It's just so much time I waste until now to just get my project work. (I use a complex webpack configuration with ts-code, however I don't mention here any webpack related things, they are general issues)


Appendix
The only help from vscode I currently seen was:
bildschirmfoto 2017-03-22 um 10 33 05
Sometimes. Very rarely. I never know when (after a restart and waiting a minute or so). I got this little error marker there if I add a not existing file property array (not tested with other config props). It hint's that the "notexists" file not exists. This is correct, but how I said, I never know when it's appear and when it's appear It's very small to recognise it.

@aight8 aight8 changed the title Feature Request: Show failed lookup path for not found modules Feature Request: Show failed lookup path for not found modules & more Mar 22, 2017
@rebornix rebornix assigned rebornix and mjbvz and unassigned rebornix Mar 22, 2017
@mjbvz mjbvz added the typescript Typescript support issues label Mar 23, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Mar 23, 2017

Thanks for the detailed report. It would be more helpful if you break this into separate issues in the future though.

Here are some thoughts on the problems listed:

  1. Try running the Go to Project Configuration command in a ts or js file. This will jump to the file's tsconfig.json or jsconfig.json. I tried exposing this info in the status bar at one point but we found it added too much visual clutter. We're still trying to sort out a general "Language Status" UI where this type of information would better fit.

  2. Ideally, when working with js, you should never have to worry specifically about which typings have been acquired for a project, only if all the available typings have been acquired. We do show a message in the status bar if typings acquisition fails, but this is currently a binary success/failure message. We are tracking improved ATA messaging with: Add Error Message To EndInstallTypesEvent on Failure TypeScript#14447

  3. I can take a look what may be going wrong here. Please open a new bug for tracking this. Include repo steps and a sample tsconfig.json.

  4. Do you mean improvising error messages for code such as import * as _ from 'no_such_module'? It would help if you split this out to its own issue as well and provide a small example project, along with a description of how the error message could be improved

We're tracking improving the error locations in tsconfig.json files microsoft/TypeScript#10384 It sounds like the tsconfig.json update problem you describe is also related to your third point about the config file not being refreshed

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Apr 6, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 10, 2017

Closing we need more info to investigate the remaining issues here. Please consider splitting this issue into separate bugs so we can better track followup on the individual pieces

Thanks

@mjbvz mjbvz closed this as completed Apr 10, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

3 participants