Unexpected indentation

[aiday-mar]

There is unexpected indentation on the first comment line:

from https://bsky.app/profile/hailey.at/post/3lahndapjdk2j

[aiday-mar]

would be fixed using #208985

[amunger]

important to note that the indent is added even with a semicolon at the end. I would argue that without a semicolon, it should indent since it can't be determined that the statement is ended (the javascript parser wouldn't know at that point)

const check =
    'true' === 'true' ?
    'true' : 'false';

Pressing enter after the last line will add an indent. Also unexpected, is that pressing enter after the = wont add an indent.

[aiday-mar]

Indentation here is determined by onEnter rules. We could add an onEnter rule to decrease indentation after having encountered a semi-colon but this would create the following false-positive case:

   const hi = `
   some text
   some text`;
const bye = 'bye';

Here the line bye is de-indented whereas it should not be. The reason this is happening is because our indentation logic relies on matching regex patterns against the current line and the previous line which misses context as to the lines prior to that. We need syntax based logic to determine reliable indentation patterns.

As for the = sign indentation, I could encode this in an onEnter rule so that this indents appropriately.