-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Proposed Native Handle API #234778
Comments
I am not sure if there is a scenario or necessary - Is there a necessary to have a change event when the nativeHandle change? |
@sandy081 at the moment, there's no scenario. We've opted for less API in this case. If something comes up, we can always add. |
Works great. Just curious what is the primary use case for this new API? |
@isidorn This was added specifically for Microsoft Auth so that we could pass the native handle down to the OS so it could render an auth dialog overtop VS Code. It's an optional property, but without it, the auth dialog was always behind VS Code. |
Makes sense. Thanks! |
Ref: #233106
Complexity: 3
Create Issue
This iteration we added a new proposed API that allows you to retrieve the native window handle of the focused window. The native window handle is an OS concept that essentially provides a pointer to a particular window. This is useful if you are interacting with native code and need to, say, render a native dialog on top of a window.
This was added specifically for Microsoft Auth so that we could pass the native handle down to the OS so it could render an auth dialog overtop VS Code. It likely won't be finalized in the near future until we get considerable interest for its use... but it should be tested nonetheless.
Prereqs
npx @vscode/dts dev
to get the proposed API fileUsing the
window.nativeHandle
I won't ask you to do anything with this native handle so you don't have to write native code, I just want you to:
The text was updated successfully, but these errors were encountered: