Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processes running in the built-in terminal do not get ended when VSCode restarts itself #23487

Closed
b4ux1t3 opened this issue Mar 28, 2017 · 3 comments
Closed

Processes running in the built-in terminal do not get ended when VSCode restarts itself #23487

b4ux1t3 opened this issue Mar 28, 2017 · 3 comments
Assignees
@Tyriar
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues

Comments

@b4ux1t3
Copy link

b4ux1t3 commented Mar 28, 2017 •
edited
Loading

  • VSCode Version: 1.10.2
  • OS Version: Windows 10.0.15063

Steps to Reproduce:

  1. Start a process in the Terminal
  2. Update or install a new extension
  3. Click "Restart" when it is done installing.
  4. When Code restarts, it will not end the process you started.

EDIT: I checked to make sure that a closed terminal window will successfully stop and processes it has started, just in case. That works as intended.

UPDATE: Cannot reproduce on Linux. Following my instructions results in the process being closed successfully when restarting VSCode for an extension update. Tried on Ubuntu 16.04 with the same VSCode version.
@Tyriar
Copy link
Member

Tyriar commented Mar 28, 2017

I'll look into this in April if there's time.

@Tyriar Tyriar added this to the April 2017 milestone Mar 28, 2017
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label windows VS Code on Windows issues labels Mar 28, 2017
@b4ux1t3
Copy link
Author

b4ux1t3 commented Mar 29, 2017

I just wanted to update that the problem persists if I use cmd.exe as my terminal.integrated.shell.windows.

@Tyriar Tyriar modified the milestones: May 2017, April 2017 Apr 23, 2017
@Tyriar
Copy link
Member

Tyriar commented May 20, 2017

Duplicate #26807

@Tyriar Tyriar closed this as completed May 20, 2017
@Tyriar Tyriar removed this from the May 2017 milestone May 20, 2017
@Tyriar Tyriar added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels May 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label windows VS Code on Windows issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @b4ux1t3