Lock icon only shows up in explorer when clicking on the file

[Tyriar]

Notice that terminalSuggestMain.js does not have the lock icon:

This is because it's showing up only after I open the file. After I close the file it remains, leading to a weird inconsistent state.

[benibenj]

@Tyriar you did not use the find widget in this scenario right (just to make sure it was not caused by some recent work)
@lramos15 you aware of this?

[bpasero]

I think we could do this but it will also add noise:

The explorer maintains decorations here:

vscode/src/vs/workbench/contrib/files/browser/views/explorerDecorationsProvider.ts

Line 19 in c5001f6

if (fileStat.isRoot && fileStat.error) {

If we decide to really show the 🔒 for all files that are readonly, just add:

if (fileStat.isReadonly) {
	return {
		letter: Codicon.lockSmall,
		tooltip: localize('readonly', "Read-only"),
	};
}

to the end.

Today decorations only appear for resolved models, coming in from:

vscode/src/vs/workbench/services/textfile/browser/textFileService.ts

Line 121 in c5001f6

provideDecorations(uri: URI): IDecorationData | undefined {

and

vscode/src/vs/workbench/services/workingCopy/common/fileWorkingCopyManager.ts

Line 237 in c5001f6

provideDecorations(uri: URI): IDecorationData | undefined {

[Tyriar]

@bpasero how about making it resolved model + open in an editor since the former is invisible to the end user? If you disagree feel free to close.

[bpasero]

I think I would either make it consistently showing in all cases or keep what we have now but not add something new that is still not consistent.

[Tyriar]

I'm on the fence, up to you. FWIW after #195701 I don't think I'll care if it's readonly until I try to edit or delete it.

[bpasero]

Yeah I will try to do that one in cleanup iteration.

[lramos15]

Sounds like we can close this as won't fix for now to not do anything confusing since #195701 has been resolved?