Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] Broken syntax highlighting for type parameters of generic method written over multiple lines #236118

Closed
ghostinpeace opened this issue Dec 14, 2024 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@ghostinpeace
Copy link

ghostinpeace commented Dec 14, 2024

Does this issue occur when all extensions are disabled? Yes

  • VS Code Version: 1.96.0
  • OS Version: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Create a new file and set the language to TypeScript.
  2. Write a generic class method and and split the type parameters across multiple lines.
class C {
  mm<
    T extends string
  >(arg: T) {}
}

Image

In the declaration of mm, the textmate scopes are not correct for extends and string. It is immediately visible as the syntax highlighting is off.

@RedCMD
Copy link
Contributor

RedCMD commented Dec 14, 2024

could you provide a code snippet please

try placing a ; on the end of the line

related microsoft/TypeScript-TmLanguage#1043

@aeschli aeschli assigned mjbvz and unassigned aeschli Dec 16, 2024
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 16, 2024
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants