Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow stepping when debugging Typescript repos #23743

Closed
isidorn opened this issue Mar 31, 2017 · 2 comments
Closed

Slow stepping when debugging Typescript repos #23743

isidorn opened this issue Mar 31, 2017 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2017

Investigate again why the stepping is slow when debuggin the Typescript repository (steps take 1 second). More details can be found here #5645
fyi @egamma

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Mar 31, 2017
@isidorn isidorn added this to the April 2017 milestone Mar 31, 2017
@isidorn isidorn self-assigned this Mar 31, 2017
@weinand
Copy link
Contributor

weinand commented Apr 5, 2017

Please try for both protocols.

@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Apr 5, 2017
@kieferrm kieferrm mentioned this issue Apr 6, 2017
15 tasks
@isidorn
Copy link
Contributor Author

isidorn commented Apr 25, 2017

I have compared the performance while debugging the checker.ts file in the typescript repository. Below I have attached three gifs illustrating this. The first one is the inspector protocol debugger which shows very good stepping performance (indistinguishable from debugging a simple file). The second shows the legacy adapter which is in the current insiders / stable and the third shows the legacy adapter with a logging bugfix made by @weinand. When comparing these two it seems like the bugfix did not have a noticable impact on the performance.

Current slowness shown only by the node adapter is due the old node debug protocol returning more data than asked for. @weinand would have to dig more in order to find the exect culprit, however that might not be necessery since we are moving towards using the inspector protocol in any case.

User workaround to get a good experience: add "protocol": "inspector" to your launch.json or update to node version 8 or greater (since then we will automatically pick the new inspector protocol)

Also created a related issue for case with much more local variables #25296

fyi @egamma

checkernode2

checkernode1

checkernode1update

@isidorn isidorn closed this as completed Apr 25, 2017
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Apr 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

3 participants