Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow QuickInput UIs to display near to the mouse-click that invoked them #237629

Closed
gjsjohnmurray opened this issue Jan 10, 2025 · 4 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@gjsjohnmurray
Copy link
Contributor

#237534 means users can drag QuickInput to a position other than top-centre. The new position is then used for all subsequent QuickInputs.

I would like this feature to be extended so an extension displaying a QuickInput can signal that it should be displayed close to the coordinates of the user interaction that triggered it.

For instance the Git extension adds a StatusBarItem displaying the name of the current branch. Clicking on this is equivalent to invoking Git: Checkout to... from Command Palette (itself a QuickInput). When invoked from Command Palette it makes sense for the list of branches to appear in the same position as CP. But when invoked by clicking in the lower left corner of the window (i.e. the StatusBarItem) I think it would be better to display the subsequent QuickInput in that region of the screen.

Simulated by dragging the QuickInput after it appeared:

Image

pinging @TylerLeonhardt @lszomoru

@gjsjohnmurray gjsjohnmurray changed the title Allow QuickInput UIs to display close to the mouse-click that invoked them Allow QuickInput UIs to display near to the mouse-click that invoked them Jan 10, 2025
@bpasero
Copy link
Member

bpasero commented Jan 11, 2025

Duplicate of #189030 ?

@gjsjohnmurray
Copy link
Contributor Author

Duplicate of #189030 ?

Agreed. I hope the recent work will result in us getting this too.

/duplicate

@vs-code-engineering vs-code-engineering bot added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 11, 2025
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2025
@gjsjohnmurray
Copy link
Contributor Author

See also #238095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants