Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in files files to include should override exclude settings? #23894

Closed
Tyriar opened this issue Apr 4, 2017 · 3 comments
Closed

Find in files files to include should override exclude settings? #23894

Tyriar opened this issue Apr 4, 2017 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality search Search widget and operation issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 4, 2017

If I say I want to find in a folder I would think that would override the exclude setting?

image

image

@roblourens
Copy link
Member

I think you can make an argument either way, and I don't have a good way to detect this or to override how ripgrep matches with a set of patterns.

@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Apr 4, 2017
@BurntSushi
Copy link

@roblourens Just speaking to ripgrep specifically: if you pass the files/directories from "files to include" as positional arguments to ripgrep (instead of just ./), then that will override everything else.

@roblourens
Copy link
Member

I do have #18334 which is basically that - my response above was more about include globs vs exclude globs in general.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

3 participants