-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test failure: Clear outputs after opening Notebook: #239504
Comments
@mjbvz added a way for the notebook editor to bail on webview fatal error #176680 Error is thrown here: https://insiders.vscode.dev/github/microsoft/vscode/blob/main/src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts#L593 The error from the logs in this case:
@mjbvz - Do you understand what went wrong here? Is there anything we can do to recover? |
from @deepak1556's comment here it sounds like there may just be a top level error in the webview script, though it's not quite the same error as was referenced there:
in that issue, vs here we had
|
If the service worker can't load, I don't think notebooks will work properly @amunger This only happens on Firefox, right? Is it consistent or just happen occasionally? The service file that it is trying to load should have existed for a while. However I have seen folks report that webview don't work on Firefox with certain security features enabled |
This was a Windows integration test and fails just enough to cause many of our integration tests to be marked 'skip'. So, getting to the bottom of this could help increase test coverage for notebooks quite a bit. |
Build: https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=317204
Changes: ff39acb...bb4a59d
The text was updated successfully, but these errors were encountered: