Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test failure: Clear outputs after opening Notebook: #239504

Open
alexr00 opened this issue Feb 3, 2025 · 4 comments
Open

Integration test failure: Clear outputs after opening Notebook: #239504

alexr00 opened this issue Feb 3, 2025 · 4 comments

Comments

@alexr00
Copy link
Member

alexr00 commented Feb 3, 2025

Build: https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=317204
Changes: ff39acb...bb4a59d

1) ipynb Clear Outputs
       Clear outputs after opening Notebook:
     Notebook Editor creation failure for document {"$mid":1,"fsPath":"Untitled-1.ipynb","_sep":1,"external":"untitled:Untitled-1.ipynb?jupyter-notebook","path":"Untitled-1.ipynb","scheme":"untitled","query":"jupyter-notebook"}

@amunger
Copy link
Contributor

amunger commented Feb 4, 2025

@mjbvz added a way for the notebook editor to bail on webview fatal error #176680

Error is thrown here: https://insiders.vscode.dev/github/microsoft/vscode/blob/main/src/vs/workbench/contrib/notebook/browser/view/renderers/backLayerWebView.ts#L593

The error from the logs in this case:

Error: Could not initialize webview: Error: Could not register service workers: 
TypeError: ServiceWorker script at https://15jrq3f462komn57ip84flcqtsrqc2mq0igbke023flk22h7c8ko.vscode-cdn.net/insider/ef65ac1ba57f57f2a3961bfe94aa20481caca4c6/out/vs/workbench/contrib/webview/browser/pre/service-worker.js?v=4&vscode-resource-base-authority=vscode-resource.vscode-cdn.net&remoteAuthority=localhost:8000 
for scope https://15jrq3f462komn57ip84flcqtsrqc2mq0igbke023flk22h7c8ko.vscode-cdn.net/insider/ef65ac1ba57f57f2a3961bfe94aa20481caca4c6/out/vs/workbench/contrib/webview/browser/pre/
encountered an error during installation..}

@mjbvz - Do you understand what went wrong here? Is there anything we can do to recover?

@amunger
Copy link
Contributor

amunger commented Feb 4, 2025

from @deepak1556's comment here it sounds like there may just be a top level error in the webview script, though it's not quite the same error as was referenced there:

Error loading webview: Error: Could not register service workers: TypeError: Failed to register a ServiceWorker for scope ...

in that issue, vs here we had

Error: Could not initialize webview: Error: Could not register service workers: TypeError: ServiceWorker script at {...} for scope ...

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 4, 2025

If the service worker can't load, I don't think notebooks will work properly

@amunger This only happens on Firefox, right? Is it consistent or just happen occasionally? The service file that it is trying to load should have existed for a while. However I have seen folks report that webview don't work on Firefox with certain security features enabled

@amunger
Copy link
Contributor

amunger commented Feb 4, 2025

This was a Windows integration test and fails just enough to cause many of our integration tests to be marked 'skip'. So, getting to the bottom of this could help increase test coverage for notebooks quite a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants