Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 javascript template syntax hightlighting not using string color #242

Closed
ddcovery opened this issue Nov 19, 2015 · 7 comments
Closed
Assignees

Comments

@ddcovery
Copy link

ES6 string template is shown with the same color than expresions/variables. On 0.9.2 version, the template was using the string color (i.e. red in default light theme) allowing a good discrimination between template and placehoders expressions.

@ddcovery ddcovery changed the title javascript template syntax hightlighting for expression in placeholders ES6 javascript template syntax hightlighting not using string color Nov 19, 2015
@a-type
Copy link

a-type commented Nov 19, 2015

#52 seems to indicate this problem is with all interpolation strings, even beyond ES6 JS. It's good to have a solid version number when this did work, though. Should help tracking it down.

@jnystrom
Copy link

I am also noticing this issue with the beta version that was not there in the previous version.

@zachlysobey
Copy link

I just posted a screenshot for this here: #130

screen shot 2015-11-20 at 3 32 45 pm

@felixfbecker
Copy link
Contributor

I have the same issue.

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2015

duplicate of #133

@aeschli aeschli closed this as completed Nov 24, 2015
@felixfbecker
Copy link
Contributor

@aeschli no, it's not. As @a-type said,

#52 seems to indicate this problem is with all interpolation strings, even beyond ES6 JS.

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2015

If Ruby also has problems with interpolated strings we need to look at this separately. Please file an issue just for Ruby. The issue with JavaScript is that we switched from our own tokenizer to a Text Mate tokenizer that doesn't support ES6.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants