Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable type not used for IntelliSense of object literal when type is declared in comment #24285

Closed
chrmarti opened this issue Apr 7, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Apr 7, 2017

  • VSCode Version: 1.11.1

Test tour #23385

When declared in TypeScript this work, in JavaScript comments it doesn't:

screen shot 2017-04-07 at 4 21 25 pm

The variable has that type and it is used when accessing it:
screen shot 2017-04-07 at 4 21 44 pm

The source:

var Vue = require('vue');

/** @type {vuejs.ComponentOption} */
var opt = {

};
opt.

/cc @roblourens

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Apr 7, 2017
@mjbvz mjbvz added the info-needed Issue requires more information from poster label Apr 12, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 12, 2017

The issue is unclear to me. Is it that when triggering suggestions inside of the opts object, you don't see any helpful suggestions for the type, but for opts.| you do?

I'm able to get either case working properly. Do I need to install the vue extension?

@chrmarti
Copy link
Collaborator Author

I can reproduce it with extensions disabled and an otherwise empty folder.

@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 12, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 12, 2017

A few TS bugs around this:

Closing as upstream

@mjbvz mjbvz closed this as completed Apr 12, 2017
@chrmarti
Copy link
Collaborator Author

Thanks @mjbvz !

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants