-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search and Ctrl + P take forever to find results #24960
Comments
This is odd since the ripgrep work has no impact on ctrl+p quick open. |
Both seemed to work great today, not sure if the most recent update today did anything? |
1.11.2 is the most recent version, unless you mean in today's insiders build? |
I tried this with a local smb network share on Ubuntu and it's really slow. With or without ripgrep, search and cmd+p are very slow. But it's also slow outside of VS Code, like if I use the system terminal, |
At work we're using VMWare and when using that as network drive I got this problem too. It takes over 5 minutes to find a file using |
Okay... this is very strange. I was testing the use cases that I was having issues with, here is what I was originally going to type:
I went to record a short video to show what I was doing and what I saw, and everything started working. I removed Is there some sort of cache for Ctrl + P or Find in Folder? It feels like a cache got warmed and now everything is really performant. I am very confused 🤔 |
It happens :) There's a cache for ctrl+p, but not Find in Folder. Maybe at the system level. |
I use a samba share on an ubuntu server and |
@Gonkers Which OS do you run VSCode on? |
Is search (in files, from the sidebar) fast? If so, that would be +1 for driving quickopen with ripgrep. |
@chrisbenti I use windows 10. |
Probably looking to tag @chrmarti |
We are using |
This problem has gone away for me, I don't know if it was some issue on my system that got patched (via Windows update) or something a VS Code update fixed, or if the gremlin in my machine died. Find in Folder and |
Tracking the use of ripgrep in #24074. Closing, thanks. (RIP gremlin) |
Making a new issue per: @bpasero #13665 (comment)
I work from a network drive to a linux server in my house. The server is Ubuntu 16.04 and I use Samba for the file sharing. Until recently (a 3-4 weeks ago?) VS Code worked fantastically. Since then search and
Ctrl + P
took forever to return results.Following Benjamin's advice I've disabled RIPgrep from preferences and everything seems to be working again (knocks on wood), I'll report back if that's not the case.
Thanks so much, love VS Code <3
Original comment: #13665 (comment)
The text was updated successfully, but these errors were encountered: