Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test column breakpoints in node2 #25194

Closed
1 task done
roblourens opened this issue Apr 22, 2017 · 1 comment
Closed
1 task done

Test column breakpoints in node2 #25194

roblourens opened this issue Apr 22, 2017 · 1 comment
Assignees
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Apr 22, 2017

Testing microsoft/vscode-chrome-debug-core#144

Complexity: 2

OS

Verify:

  • You can set column BPs with shift+f9
  • The BPs go to a reasonable column and the debugger stops in that spot
  • You can set multiple column BPs on a line

If it seems like the BP ends up on a weird column, you can check with Chrome devtools. The blue marks inline are valid BP locations.

image

Also test with Node < 8. The column BP behavior is kind of undefined there. Sometimes a BP will go to the next line or a confusing spot, just based on what v8 decides to do. But we have to detect whether it supports a certain API so just sanity check it that you don't see errors or totally broken behavior.

@alexdima
Copy link
Member

Tested with the v8 nightly and node v7.9.0 and in both cases it appears to work fine:

image

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants