-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node cached data for node_modules #25229
Comments
Any benchmarks of this? |
Nothing scientific but using cached data speeds up code loading by roughly 50%. JS code from node_modules are around 20-25% of the total code we load at startup. For node_module tho it seems that don't gain that must (maybe because things are scattered in many little files) Using cached data Not using cached data (but also not generating it) You can see that loading |
Alright. So should make some difference with large workspaces. Will test on my machine tomorrow. |
I'm looking for provide startup performance benchmarks for further improving 😄 |
No, that is just about loading JS code which is always the same chunk, independent of the workspace size |
Loading node modules is around 20% of loading code and we should look into making that part faster using the trick of code cached data.
The text was updated successfully, but these errors were encountered: