Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe should work with any choosen gesture #25447

Closed
aeschli opened this issue Apr 26, 2017 · 4 comments
Closed

Swipe should work with any choosen gesture #25447

aeschli opened this issue Apr 26, 2017 · 4 comments
Assignees
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Apr 26, 2017

Testing #25325

  • to get swipe working I have to change the OSX preferences as shown here:
    image
  • why can't I choose to swipe pages with 2 fingers?
@bpasero
Copy link
Member

bpasero commented Apr 26, 2017

We should follow up with Electron on this, we are just using the swipe event and that only seems to support 3-finger swipe: https://github.com/electron/electron/blob/master/docs/api/browser-window.md#event-swipe-macos

@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 26, 2017
@bpasero bpasero added this to the Backlog milestone Apr 26, 2017
@pdfowler
Copy link

pdfowler commented May 4, 2017

As someone who has always used the "Two-Finger Scroll" setting, switching to "3 Finger Swipe" is extremely disorienting. Two finger mode is akin to "natural scrolling" that Apple brought about with the iPhone; pages come in from the right, and you push them back to the right to go back. The Three finger mode feels "inverted" coming from this habit.

Hopefully this can be figured out here or in Electron - I doubt Apple will be adding a "Swipe Direction: Natural" setting to the "More Gestures" screen 😝

@brennanMKE
Copy link

I also use the 2 finger swipe regularly with Xcode and Safari. I have also mapped the equivalent hot keys in VS Code to match Xcode. I want the editors I use to use the same keys and gestures so I am not disoriented. If it has to be added from the Electron side I'd have it align well with how the Mac works. Instead of just calling it swipe, there should be a distinction between swiping between pages/documents and swiping between full screen apps. I use 2 for pages/documents and 3 for screens.

The gesture also cannot simply be a single event. It has to have a start, progress and end so that it can move the current document forward and backward as the user swipes. See apps like Safari and Xcode for the behavior. And for 3 finger swipes you can create multiple virtual screens and full screen apps and swipe between them.

@bpasero bpasero added electron Issues and items related to Electron feature-request Request for new features or functionality trackpad/scroll Trackpad device issues and removed trackpad/scroll Trackpad device issues labels Nov 13, 2017
@bpasero
Copy link
Member

bpasero commented Nov 14, 2017

Closing, no plans to work on this currently.

@bpasero bpasero closed this as completed Nov 14, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants