Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons should support themes #25457

Closed
Tyriar opened this issue Apr 26, 2017 · 5 comments
Closed

Icons should support themes #25457

Tyriar opened this issue Apr 26, 2017 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality themes Color theme issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 26, 2017 •
edited
Loading

#25328

  • VSCode Version: Code - Insiders 1.12.0-insider (48ae6e3, 2017-04-26T06:32:53.505Z)
  • OS Version: Linux x64 4.10.0-19-generic
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.9.3
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.2.0
theme-sapphire Tyriar 0.1.0
vscode-svgviewer cssho 1.4.0
tslint eg2 0.12.0
git-project-manager felipecaputo 1.3.2
md-navigate jrieken 0.0.1
vscode-scss mrmlnc 0.6.2
vetur octref 0.6.3
seti-icons qinjia 0.1.3

Related: #8017

image
@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues labels Apr 26, 2017
@bpasero bpasero added this to the Backlog milestone Apr 26, 2017
@aeschli
Copy link
Contributor

aeschli commented Apr 27, 2017

Icons already do support themes in the way that they are supposed to provide light and dark icons.
There are currently no plans to go further than that.

@aeschli aeschli removed their assignment Apr 27, 2017
@bpasero bpasero removed their assignment Apr 27, 2017
@bpasero bpasero removed this from the Backlog milestone Apr 27, 2017
@bpasero
Copy link
Member

bpasero commented Apr 27, 2017

#23475

@bpasero bpasero closed this as completed Apr 27, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 27, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Apr 27, 2017

FYI if icons are SVGs we should be able to use some tricks to style them from the outside the .svg files, so we could set their color(s).

@bpasero
Copy link
Member

bpasero commented Apr 28, 2017

@Tyriar that is not possible because we use CSS with SVG, we have checked all tricks for status bar icons and activity bar. Only webkit-mask was possible, but has lots of drawbacks.

@Tyriar
Copy link
Member Author

Tyriar commented May 1, 2017

It should be possible if we change how we do the icons though using standalone="no" in the SVG.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @aeschli