Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignored items not excluded from search #25730

Closed
borekb opened this issue May 1, 2017 · 4 comments
Closed

gitignored items not excluded from search #25730

borekb opened this issue May 1, 2017 · 4 comments
Assignees
@roblourens
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues

Comments

@borekb
Copy link

borekb commented May 1, 2017 •
edited
Loading

A possible bug in use .gitignore to ignore search inside files and folders #78.

I have this workspace open in VSCode 1.11:

Path Contents
/.gitignore a.txt
/a.txt aaa
/dir/.gitignore b.txt
/dir/b.txt aaa

Search for "aaa" with "Use Ignore Files" enabled yields this:

image

These two search results shouldn't show up, should they? I've tried this on a workspace where Git repo actually exists (.git present) and where it doesn't with the same result.

Repro project: gitignoresearch.zip
@roblourens
Copy link
Member

Are the files open? They will still be searched if they are open.

@roblourens roblourens added the info-needed Issue requires more information from poster label May 24, 2017
@borekb
Copy link
Author

borekb commented May 25, 2017

You're right, when I open a.txt but not b.txt, only a.txt shows up in the search results:

image

Still, this feels like a bug / unexpected behavior to me. The search panel should follow gitignore rules if it has a toggle for it.

@roblourens
Copy link
Member

roblourens commented May 25, 2017 •
edited
Loading

Maybe in the future, right now I don't have a straightforward way to do it.

@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues and removed info-needed Issue requires more information from poster labels May 25, 2017
@roblourens
Copy link
Member

/duplicate of #31819

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 21, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@borekb @roblourens