Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Command: Copy All - Current panel output (no focus needed) #26963

Closed
cleidigh opened this issue May 19, 2017 · 6 comments
Closed

Add Command: Copy All - Current panel output (no focus needed) #26963

cleidigh opened this issue May 19, 2017 · 6 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues output Output channel system issues terminal General terminal issues that don't fall under another label ux User experience issues
Milestone

Comments

@cleidigh
Copy link
Contributor

As a continuation of the newly added "Copy All" ContextMenu option @isidorn added
it would also be very useful to have a pure keyboard access for this and other output windows.

As far as I can tell from experimentation and looking at all the commands, I cannot seem
to copy terminal output using only the keyboard . if one word is clicked on with the mouse
the Terminal: Copy Selected would apply. There does not seem to be a way to enlarge the selection
with the keyboard.
It would also be helpful with moving output.

A Copy All for any output would be highly useful and much easier for keyboard only users.
I looked at the extension API and I don't think this can be done with an extension , but I may have missed something. It still makes sense to me as a built-in command, .

@Tyriar
Copy link
Member

Tyriar commented May 19, 2017

@cleidigh so the command would copy the entire buffer of the terminal/debug console/output panel, not just the visible parts? I was planning on adding a Select all command to the terminal which would basically solve this issue I think.

@isidorn I'm a little worried about the lack of consistently between the panels.

@Tyriar Tyriar added debug-console terminal General terminal issues that don't fall under another label output Output channel system issues ux User experience issues labels May 19, 2017
@Tyriar Tyriar added this to the Backlog milestone May 19, 2017
@cleidigh
Copy link
Contributor Author

@Tyriar
SelectAll as a command eg assignable to a keyboard shortcut? that would certainly solve the select issue.
I was just thinking a global command independent of the particular output window including focus
what allow you to paste into an editor really quickly.
just as an aside , I have also noticed some of the inconsistencies such a select and scroll method
Bear in mind my comments and observations are almost entirely derived from keyboard only use
combined mouse and keyboard approaches are killer for disabled users.

@isidorn
Copy link
Contributor

isidorn commented May 19, 2017

@Tyriar yeah the panels are completely incosistent since they all use different things under the hood, debug console - tree, output - editor, terminal - your xTerm. Unfortunetely due to that I believe they will never be consistent.

@cleidigh thanks for the idea, however as I pointed above it is hard to have one command that will rule them all, I mean all the panels. For instance this command does not make sense for the problems panel and the output (since in the output a user can simply press ctrl + A to select everything)

When looking for PR we love small things that solve one issue at a time and do not change the whole world. If you would like to contribute I agree that the debug console currently has the problem that copy all is not keyboard accessibile, but instead of adding command in the command palette I might prefer adding a title command next to the clear console. For that we would need an icon but I can look for that.
As for this issue in the terminal I think @Tyriar is better to answer that part

Thank you

@cleidigh
Copy link
Contributor Author

@isidorn
@Tyriar
Yes I can see that it doesn't have full parallelism between output types
the individual Select all commands for the appropriate panels will solve the key problem

@Tyriar
Copy link
Member

Tyriar commented May 22, 2017

@cleidigh here's the issue for select all in the terminal #15199. It would be great if you could create a new issue for debug/output if needed and close this one off 😄

@isidorn
Copy link
Contributor

isidorn commented May 22, 2017

Agree with @Tyriar -> closing this one as it is too general
Thanks for understanding

@isidorn isidorn closed this as completed May 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues output Output channel system issues terminal General terminal issues that don't fall under another label ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants