Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to implementation (and implementation code lens) are missing #27403

Closed
eamodio opened this issue May 28, 2017 · 4 comments
Closed

Go to implementation (and implementation code lens) are missing #27403

eamodio opened this issue May 28, 2017 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster typescript Typescript support issues

Comments

@eamodio
Copy link
Contributor

eamodio commented May 28, 2017

  • VSCode Version: Code - Insiders 1.13.0-insider (770206a, 2017-05-26T05:14:23.944Z)
  • OS Version: Windows_NT ia32 10.0.16199

Steps to Reproduce:

  1. Open the vscode codebase
  2. Open an interface with known implementations
  3. 🐛 Go to implementation menu item, and implementation code lens are missing

FYI, this all still works fine on 1.12

Here is the output from the TypeScript channel:

[Info  - 12:22:10 PM] Using tsserver from: c:\Program Files (x86)\Microsoft VS Code Insiders\resources\app\extensions\node_modules\typescript\lib\tsserver.js
[Info  - 12:22:10 PM] Forking TSServer
PATH: undefined
@mjbvz mjbvz added the typescript Typescript support issues label May 30, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 30, 2017

We removed go to implementation from the context menu: #25913 You still should be able to run the go to implementation command or use the Go menu to run go to implementation

For the code lens, can you check that you have "typescript.implementationsCodeLens.enabled": true and "editor.codeLens": true set

@mjbvz mjbvz added the info-needed Issue requires more information from poster label May 30, 2017
@eamodio
Copy link
Contributor Author

eamodio commented May 30, 2017

@mjbvz that's too bad I quite liked it on the context menu -- very discoverable, where as having both peek definition and go to definition, feels quite redundant ;)

I definitely did have both of those settings on, but I can no longer reproduce this in the latest nightly.

@mjbvz
Copy link
Collaborator

mjbvz commented May 31, 2017

ok, glad to hear the codelenses are working again. Perhaps just a bad insiders build

Yes, there was some discussion about the context menu change but the main reason we removed it is that compared to go to definition, go to implementation usually only applies to a handful of locations in a file. We may revisit the context menu items in the future though and also are tracking allowing the context menu to be configured with #9285

@mjbvz mjbvz closed this as completed May 31, 2017
@chenjiaxi1993
Copy link

VSCode version: 1.16.0-insider
go to implementation cmd does not work. Is the cmd is removed?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

3 participants