Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Emmet: Update image size" breaks formatting #27977

Closed
jens1o opened this issue Jun 3, 2017 · 5 comments
Closed

"Emmet: Update image size" breaks formatting #27977

jens1o opened this issue Jun 3, 2017 · 5 comments
Assignees
@ramya-rao-a
Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2017

Comments

@jens1o
Copy link
Contributor

jens1o commented Jun 3, 2017

  • VSCode Version: Code - Insiders 1.13.0-insider (f977399, 2017-06-02T10:54:04.063Z)
  • OS Version: Windows_NT ia32 10.0.15063
  • Extensions:
Extension Author Version
vscode-reveal evilz 0.0.9
php-intellisense felixfbecker 1.3.0
auto-close-tag formulahendry 0.4.2
php-docblocker neilbrayfield 1.2.0
vscode-icons robertohuertasm 7.8.1
Material-theme zhuangtongfa 2.8.4

1ea1315c-d8b4-4955-833f-f5d1ef4dcecf
@vscodebot vscodebot bot added the insiders label Jun 3, 2017
@ramya-rao-a
Copy link
Contributor

@jens1o I am guessing this happens in stable build as well?

I haven't implemented Update Image Size using the new emmet yet.

@ramya-rao-a ramya-rao-a added emmet Emmet related issues bug Issue identified by VS Code Team member as probable bug labels Jun 5, 2017
@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 5, 2017
@jens1o
Copy link
Contributor Author

jens1o commented Jun 5, 2017 •
edited
Loading

Yes, it happens in stable also.

@ramya-rao-a ramya-rao-a modified the milestones: July 2017, June 2017 Jun 21, 2017
@jens1o jens1o mentioned this issue Jun 22, 2017
Closed
@ramya-rao-a
Copy link
Contributor

With 0bee43b and 56eebb2, the Emmet: Update Image Size is now implemented using the new modular emmet model.

@jens1o Can you give this a try on Monday's Insiders, test out the feature and file issues if you find any?

@jens1o
Copy link
Contributor Author

jens1o commented Jul 23, 2017

Wow! Thanks! I'm looking forward to tomorrow!

Yeah, I'm going to do that. :)

@kieferrm kieferrm mentioned this issue Jul 24, 2017
Closed
39 tasks
@ramya-rao-a ramya-rao-a added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed bug Issue identified by VS Code Team member as probable bug labels Aug 1, 2017
@ramya-rao-a
Copy link
Contributor

Note to verifier:

Converting this issue from bug to feature request as this issue was used to track the Update Image Size feature in the new emmet.

See https://docs.emmet.io/actions/update-image-size/ to learn more

Test in

  • css/scss/less files
  • inside the style tag in an html file
  • in img node in an html file

@roblourens roblourens added the verified Verification succeeded label Aug 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2017
Development

No branches or pull requests
4 participants
@roblourens @jens1o @ramya-rao-a and others