Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for a inline group on a custom view item to show on hover -- like the search close x #28634

Closed
eamodio opened this issue Jun 13, 2017 · 6 comments
Closed

Allow for a inline group on a custom view item to show on hover -- like the search close x #28634

eamodio opened this issue Jun 13, 2017 · 6 comments
Assignees
@sandy081
Labels
api feature-request Request for new features or functionality tree-views Extension tree view issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2018

Comments

@eamodio
Copy link
Contributor

eamodio commented Jun 13, 2017

  • VSCode Version: Code - Insiders 1.14.0-insider (bbcd10a, 2017-06-13T05:13:35.880Z)
  • OS Version: Windows_NT ia32 10.0.16215

We can add items to the navigation group to the view/title of a custom view, but it would be great if we could also add them to the view/item/context as well. Similar to the behavior with the close button on the search results.
@vscodebot vscodebot bot added the insiders label Jun 13, 2017
@jrieken jrieken added the feature-request Request for new features or functionality label Jun 14, 2017
@sandy081
Copy link
Member

Duplicates #27823

@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 14, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
@sandy081 sandy081 reopened this Jan 12, 2018
@sandy081 sandy081 added tree-views Extension tree view issues and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jan 12, 2018
@sandy081 sandy081 added this to the January 2018 milestone Jan 12, 2018
@sandy081 sandy081 changed the title Allow for a navigation group on a custom view item to show on hover -- like the search close x Allow for a inline group on a custom view item to show on hover -- like the search close x Jan 15, 2018
@sandy081
Copy link
Member

Name of the group to be added into is inline.

Example:

"view/item/context": [
	{
		"command": "jsonOutline.refreshNode",
		"when": "view == jsonOutline",
		"group": "inline"
	}
]

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Jan 29, 2018
@chrmarti
Copy link
Contributor

chrmarti commented Feb 1, 2018

We couldn't get this to work in the latest insiders using the tree-view-sample.

@chrmarti chrmarti reopened this Feb 1, 2018
@chrmarti chrmarti added the verification-found Issue verification failed label Feb 1, 2018
@sandy081
Copy link
Member

sandy081 commented Feb 1, 2018

This was broken due to the changes done to the action items infrastructure. Fixed it.

@sandy081 sandy081 removed the verification-found Issue verification failed label Feb 1, 2018
@chrmarti
Copy link
Contributor

chrmarti commented Feb 2, 2018

The item is missing from the arguments to the command in the example I look at.

@chrmarti chrmarti reopened this Feb 2, 2018
@chrmarti chrmarti added the verification-found Issue verification failed label Feb 2, 2018
@sandy081
Copy link
Member

sandy081 commented Feb 2, 2018

This was also due to the refactorings in menu items infrastructure. Fixed it.

@sandy081 sandy081 closed this as completed Feb 2, 2018
@sandy081 sandy081 removed the verification-found Issue verification failed label Feb 2, 2018
@chrmarti chrmarti added the verified Verification succeeded label Feb 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
api feature-request Request for new features or functionality tree-views Extension tree view issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
5 participants
@eamodio @jrieken @chrmarti @sandy081 @ramya-rao-a