Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks 2.0 npm run compile task as a preLaunchTask, Code won't start debugger #29014

Closed
ytimenkov opened this issue Jun 19, 2017 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Milestone

Comments

@ytimenkov
Copy link

  • VSCode Version: Code 1.13.1 (379d2ef, 2017-06-14T18:21:47.485Z)
  • tasks.json:
{
    "version": "2.0.0"
}
  • launch.json
// A launch configuration that compiles the extension and then opens it inside a new window
{
    "version": "0.1.0",
    "configurations": [
        {
            "name": "Launch Extension",
            "type": "extensionHost",
            "request": "launch",
            "runtimeExecutable": "${execPath}",
            "args": ["--extensionDevelopmentPath=${workspaceRoot}" ],
            "stopOnEntry": false,
            "sourceMaps": true,
            "outFiles": [
                "${workspaceRoot}/out/*",
                "${workspaceRoot}/out/src/*",
                "${workspaceRoot}/out/test/*"
            ],
            "preLaunchTask": "run compile",
            "smartStep": true
        }
    ]
}
  • Expected result: When I press F5, VS Code runs npm run compile and then starts debugger.
  • Actual result:
    • When I press F5 first time VS Code just compiles and doesn't start debugger, just showing a spinning line in the status bar.
    • Subsequent attempts to run actually starts debugger and work as expected.
    • When I execute "Terminate running task" command I get error message:
      image

Related to: #28235

@dbaeumer dbaeumer added info-needed Issue requires more information from poster tasks Task system issues labels Jun 21, 2017
@dbaeumer
Copy link
Member

@ytimenkov where does the run compile task come from. Can you execute that task from F1 > Run Task ?

@dbaeumer
Copy link
Member

Info is in #29013

@dbaeumer dbaeumer added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 21, 2017
@dbaeumer dbaeumer added this to the June 2017 milestone Jun 21, 2017
@ytimenkov
Copy link
Author

@dbaeumer This task is provided by npm built-in extension, activated when tasks.json has version 2.0.0.
I suspect there are either some glitches in handling isBackground in new tasks implementation (or it is not supported or implemented in npm extension) or tsc watch requires special parser which lets vscode know when initial job is done and task went into watch mode.

@dbaeumer
Copy link
Member

This for addressed with the fix done for #29013. Marking as dup: #29013

@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Projects
None yet
Development

No branches or pull requests

3 participants