Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode does not exit delve properly #29089

Closed
firelizzard18 opened this issue Jun 20, 2017 · 3 comments
Closed

VSCode does not exit delve properly #29089

firelizzard18 opened this issue Jun 20, 2017 · 3 comments
Assignees

Comments

@firelizzard18
Copy link

  • VSCode Version: Code 1.13.1 (379d2ef, 2017-06-14T18:13:05.928Z)
  • OS Version: Darwin x64 16.6.0
  • Extensions:
Extension Author Version
aurelia AureliaEffect 0.3.4
vscode-npm-script eg2 0.2.0
task-master ianhoney 0.1.39
quicktask lkytal 2.8.0
Go lukehoban 0.6.62
debugger-for-chrome msjsdiag 3.1.4

Steps to Reproduce:

  1. Open a Golang project
  2. Debug something
  3. Stop debugging (via Stop, aka the red square or Shift+F5)

delve is the debugger for golang, or at least it's the one that the Go extension uses. When you debug something with delve, it creates a large binary file in the current directory. If you debug a main function (dlv debug), you get 'debug'. If you debug a test function (dlv test), you get 'debug.test'.

In normal delve usage, when you're done, you quit delve. Delve then deletes this file. Apparently VSCode gracelessly terminates (SIGKILL?) delve, which means the file sticks around.

@firelizzard18
Copy link
Author

This may be a regression from microsoft/vscode-go#765 which fixed microsoft/vscode-go#438

@weinand
Copy link
Contributor

weinand commented Jun 20, 2017

Yes, VS Code terminates debug adapters "gracelessly" (and we are planning to make this more graceful in the future).
But for now the VS Code Go debugger could 'quit' delve nicely when receiving a DisconnectRequest from VS Code. This is always the last request sent from VS Code to the debug adapter before killing the debug adapter. And VS Code kills the VS Code Go debugger only after it has received the response from the DisconnectRequest. So the debug adapter can delay the killing enough so that delve could do its cleanup.

@ramya-rao-a
Copy link
Contributor

This issue was moved to microsoft/vscode-go#1345

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants