Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Restore UI state for empty windows #29249

Closed
3 tasks done
bpasero opened this issue Jun 22, 2017 · 1 comment
Closed
3 tasks done

Test: Restore UI state for empty windows #29249

bpasero opened this issue Jun 22, 2017 · 1 comment

Comments

@bpasero
Copy link
Member

bpasero commented Jun 22, 2017

Complexity: 5
Refs: #207

We always persist and restore all UI state for windows that have a folder opened via the local storage of the browser. For that we used the folder path as identifier to know which UI state to restore. This does however not work if you open an empty folder where we do not have such a folder path for identifying the UI state. The fix was to introduce a new identifier for empty windows to save and load UI state via local storage. This identifier is derived from the backup location for hot exit which we always have to enable hot exit scenarios for any window (folder or empty).

Basic Functionality

  • verify an empty window restores its UI state (e.g. opened files) between restarts
  • verify this also works for window reload
  • verify this also restores the windows dimensions and location on screen
  • verify the empty window is no longer restored once you
    • open a specific file or folder from the command line
    • open a specific file or folder from the context menu of the OS explorer
    • open up with the "-n" flag to force an empty window
  • verify that opening a new window from the running instance always opens it with default UI state (= empty)

New Setting

We always had a setting window.reopenFolders to control the windows that should be restored (none, one or all). This setting has been renamed to window.reopenWindows to better reflect the scenario of restoring empty windows.

We still want to support the old setting, so verify that

  • window.reopenFolders: none restores no window (neither empty, nor folders)
  • window.reopenFolders: all restores all windows (empty and folders) and their size/location on screen

Verify the new setting:

  • window.reopenWindows: none restores no window (neither empty, nor folders)
  • window.reopenWindows: folders only restores windows that had folders opened
    • window.reopenWindows: all restores all windows (empty and folders) and their size/location on screen

Hot Exit

If you have made changes to files in either an empty window or window with folder opened we always restore that window, independent of any setting.

  • verify that UI state and window size/location on screen gets restored for all windows that have dirty files independent from the window.reopenWindows setting
@rebornix
Copy link
Member

Except #29684, others all look as expected.

@rebornix rebornix removed their assignment Jun 27, 2017
@roblourens roblourens removed their assignment Jun 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants