Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New emmet: possible abbreviation mismatch #29302

Closed
Ser-Gen opened this issue Jun 23, 2017 · 4 comments
Closed

New emmet: possible abbreviation mismatch #29302

Ser-Gen opened this issue Jun 23, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@Ser-Gen
Copy link

Ser-Gen commented Jun 23, 2017

  • VSCode Version: Code 1.13.1 (379d2ef, 2017-06-14T18:21:47.485Z)
  • OS Version: Windows_NT ia32 10.0.15063

Steps to Reproduce:

  1. Open css file
  2. Enter minh and press tab
  3. Get min-width: ;

vscode_newemmet_css_minh

What is the expected behavior?
Get min-height: , as it happens on emmet site

vscode_insiders_emmet_css_demo

@vscodebot vscodebot bot added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues labels Jun 23, 2017
@vvs
Copy link

vvs commented Jun 23, 2017

Looks like a duplicate of our good old friend #28933.

Essentially, Emmet has mih and miw shortcuts for min-height and min-width, and when you type minh, there is no such shortcut, so VS Code just defaults to the closest it finds, and in this case it is 'mih'.

Well, at least, that's not as bad as other examples in #28933 :)

@ramya-rao-a
Copy link
Contributor

when you type minh, there is no such shortcut, so VS Code just defaults to the closest it finds

Actually that's not true. All the fuzzy logic matching of given shortcut to css property is done by the emmet module https://github.com/emmetio/expand-abbreviation

VS Code just passes the abbreviation to this module and displays the return value.

This is a regression in emmet itself. The old emmet gives min-height for minh.

@ramya-rao-a
Copy link
Contributor

This issue was moved to emmetio/atom-plugin#25

@ramya-rao-a ramya-rao-a added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jun 26, 2017
@ramya-rao-a ramya-rao-a added this to the July 2017 milestone Jun 26, 2017
@ramya-rao-a
Copy link
Contributor

This specific case of minh is fixed in VS Code by sorting the emmet results appropriately.

The root cause of the issue is still to be fixed upstream.

@chrmarti chrmarti added the verified Verification succeeded label Aug 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants